Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONCEPT: Support all scripting langs #2027

Closed
Kreyren opened this issue Jul 1, 2019 · 10 comments
Closed

CONCEPT: Support all scripting langs #2027

Kreyren opened this issue Jul 1, 2019 · 10 comments

Comments

@Kreyren
Copy link
Contributor

Kreyren commented Jul 1, 2019

I was working on this concept that i think could be adapted in phoenicis.

  • Simple to adapt
  • Self-Sufficient -> No additional maintainance

Current

Currently we support only javascript with plan to support lutris scripts(https://github.com/PhoenicisOrg/phoenicis/issues/1716).

Expected

Support all scripting langs

How?

  1. Make phoenicis execute all scripts (core functionality)
  2. Adapt sandbox

Reasoning: We can make sandbox with a work and image directory where all the work would be done in work directory (What is currently beeing done using javascript) and then moved to image where image would have files alike: /home/$USER/Games/somegame which would be merged in live system if work was successful.

I believe that if we base scripts around making final configuration in image directory that we could use all scripting langs since we would expect from all these to provide this final configuration in image directory assuming that the work could be done in work directory.

Theoretically we would only have to adapt sandbox (which we are currently using anyway in a form of containers) and change javascript to output scripts in image from where they would be merged into a live system.


Inspired by paludis/portage concept.

@plata
Copy link
Collaborator

plata commented Jul 2, 2019

What's the advantage for our users?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 2, 2019

@plata Users would be able to use any scripting lang to install phoenicisapp for contribution without additional maintainance.

@plata
Copy link
Collaborator

plata commented Jul 2, 2019

So? (I still do not see the benefit)

@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 2, 2019

@plata Meaning that we could use any script to install phoenicisapp which is huge benefit.

@plata
Copy link
Collaborator

plata commented Jul 2, 2019

Why is it a benefit?

  • Does it provide support for any additional app? - No.
  • Does it increase maintenance effort? - Yes.
  • Does it increase the complexity and thus the potential for errors? - Yes.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 2, 2019

Does it provide support for any additional app?

Yes, because i prefer making bash/ion script instead of depending on provided imports + We can use POL4 and lutris scripts.

Does it increase maintenance effort?

Not really since you maintain javascript scripts and rest can be community maintained or built from scratch or used in separate repositories.

Does it increase the complexity and thus the potential for errors?

Depends on the script where my scripts are always perfect -> no errors

@madoar
Copy link
Collaborator

madoar commented Jul 4, 2019

@Kreyren you're free to provide support for other scripting languages. Our focus is on providing support for JavaScript based scripts. This doesn't mean that we won't agree to adding support for other scripting languages, we just won't add them ourselves.

Feel free to provide a PR, if the extension is good and it fits inside Phoenicis I see no reason why we shouldn't merge it.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 5, 2019

@madoar Making MR from me is not an option since i would probably have to change a way how phoenicis handles scripts which would be pita to agree on + i suck at java.

I will probably make the MR if none else wants to do it, but i would maintain it in my fork probably..

Currently willing to provide simple javascripts scripts and bash/shell code.

@qparis qparis closed this as completed Jul 5, 2019
@ghost
Copy link

ghost commented Jan 25, 2021

I would find that feature cool,cause it would be nice to use Lutris installers,cause that's the mainstreaming platform people make scripts for.

@plata
Copy link
Collaborator

plata commented Jan 26, 2021

See PhoenicisOrg/scripts#788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants