potential bug: forgetting to check the return value of openssl API 'X509_STORE_CTX_get_current_cert'

[Zero0one1]

According to the OpenSSL API document,

X509_STORE_CTX_get_current_cert() returns the certificate which caused the error or NULL if no certificate is relevant to the error.

X509_STORE_CTX_get_current_cert() was never NULL. Applications should check the return value before printing out any debugging information relating to the current certificate.

So it will be safer to check cert first before using it.

aprx/ssl.c

Lines 486 to 494 in 13c6e79

	cert = X509_STORE_CTX_get_current_cert(x509_store);
	err = X509_STORE_CTX_get_error(x509_store);
	depth = X509_STORE_CTX_get_error_depth(x509_store);
	sname = X509_get_subject_name(cert);
	subject = sname ? X509_NAME_oneline(sname, NULL, 0) : "(none)";
	iname = X509_get_issuer_name(cert);
	issuer = iname ? X509_NAME_oneline(iname, NULL, 0) : "(none)";