refcounted_he_(new|fetch)_pvn: Don't roll-own code #22808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
force-pushed
the
hv_fetch
branch
2 times, most recently
from
f7257b9 to
001f17c
Compare
khwilliamson
added
the
squash-before-merge
tonycoz
approved these changes
Dec 16, 2024
The indentation for some lines in one function was only 2 spaces. Remove trailing blanks And This will minimize the diff listing in the next commit when white space isn't ignored.
The new function utf8_to_bytes_new_pv() does a better job than these code sections that are nearly duplicates of each other. It's better for several reasons, such as that for long keys, it checks a word at a time if it is downgradable. This is a follow on to Perl#22638, which was closed without the original commits that this replaces.
khwilliamson
force-pushed
the
hv_fetch
branch
from
001f17c to
1d76b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new function utf8_to_bytes_temp_pv() does a better job than these
code sections that are nearly duplicates of each other.
It's better for several reasons, such as that for long keys, it checks a
word at a time if it is downgradable.
This is a follow on to #22638, which was closed without the original
commits that this replaces.