Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do about Negan, the Cold-Blooded getting "renamed" to Malik, Grim Manipulator #11620

Open
vorpal-buildbot opened this issue Aug 20, 2023 · 6 comments
Assignees
Labels
+ bug * monolith Concerns the repo as a whole + question Unclear path forward to resolve

Comments

@vorpal-buildbot
Copy link
Contributor

Reported on Discord by bakert#0

@github-actions github-actions bot added the triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling label Aug 20, 2023
@bakert
Copy link
Member

bakert commented Aug 23, 2023

I renamed all the Walking Dead cards in deck_card to the Universes Within name but we need to support a "real" name being changed and transferred into the "flavor_name" property in future. Tricky.

@silasary silasary self-assigned this Aug 23, 2023
@bakert
Copy link
Member

bakert commented Aug 27, 2023

We probably need to retroactively edit legal_cards.txt for a bunch of seasons?

While we are in there we could remove Precursor Golem - Sketch and the other - Sketch cards that slipped through in (I think) MOM.

@silasary
Copy link
Member

If everything works correctly, our internal code should natively support both names everywhere (including the legal cards list), so editing history isn't mandatory.

@bakert
Copy link
Member

bakert commented Sep 6, 2023

I'm not sure if we're done here (bar #11641) or if we have more to do still

@bakert bakert added + bug + question Unclear path forward to resolve * monolith Concerns the repo as a whole labels Sep 6, 2023
@github-actions github-actions bot removed the triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling label Sep 6, 2023
@silasary
Copy link
Member

#11670 handles reading rotation files. I feel like we're starting to get towards the edge-cases now.

@bakert
Copy link
Member

bakert commented Oct 8, 2023

#11700 covers league signup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+ bug * monolith Concerns the repo as a whole + question Unclear path forward to resolve
Projects
None yet
Development

No branches or pull requests

3 participants