Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete qsub_build.sh script #3396

Merged

Conversation

harshagr70
Copy link
Contributor

Description

This PR removes the qsub_build.sh script from the repository as it has been determined to be obsolete and no longer in active use.

fixes

fixes #3133

Types of changes

I have removed the script - qsub_build.sh that was no longer in use.

Checklist:

  1. limited activity in logs - the logs show only a few reference to scripts/qsuib_build.sh which suggests that its not frequently used and updates
  2. no direct reference - i found no direct reference for the script and also found no functions calling for the script , also checked for the workflow files but found no direct reference to the script .
  3. also i have checked for the script as mentioned in the comment - referring to docker/depends/pecan.depends.R , this script caters the same functionality as of the qsuib_build.sh .
  4. I found no reference or any detail about the script in the documentation .
  5. The last commits made to that script was about 9 years ago and since its not maintained and updated , the script currently do not caters the requirements of installing the dependencies .

Concluding all these points its evident that the script is no longer in use hence its completely safe to remove the script .

Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing the PR and especially for documenting the reasoning so thoroughly! I agree this can go and don't know of any other files that need to change because of it.

@infotroph infotroph merged commit 84e29d1 into PecanProject:develop Nov 18, 2024
15 of 22 checks passed
@harshagr70
Copy link
Contributor Author

thank you !! @infotroph for reviewing and merging the changes !

@harshagr70 harshagr70 deleted the GH-3133-remove-obsolete-scripts branch November 18, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove obsolete scripts/qsub_build.sh
2 participants