Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a named volume for the Bety logs mountpoint #3352

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

infotroph
Copy link
Member

Best I can tell nothing gets written to this, but because the Bety image specifies this path as a VOLUME, we were creating a new anonymous-but-permanent volume every time Compose spun up. Having one named one that stays empty seems a touch cleaner.

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Best I can tell nothing gets written to this, but because the Bety image
specifies this path as a VOLUME, we were creating a new anonymous-but-permanent
volume every time Compose spun up
@infotroph infotroph requested a review from robkooper August 3, 2024 08:20
Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should add this to the bety repo as well, just to be consistent.

infotroph added a commit to PecanProject/bety that referenced this pull request Aug 4, 2024
@infotroph
Copy link
Member Author

probably should add this to the bety repo as well, just to be consistent.

👍 Done in PecanProject/bety#762

@infotroph infotroph merged commit 7592eab into PecanProject:develop Aug 4, 2024
12 of 13 checks passed
@infotroph infotroph deleted the bety-gets-a-volume branch August 4, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants