Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update write.configs.ed.R #3232

Closed
wants to merge 1 commit into from
Closed

Update write.configs.ed.R #3232

wants to merge 1 commit into from

Conversation

mdietze
Copy link
Member

@mdietze mdietze commented Nov 3, 2023

third straw on isFalse

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

third straw on isFalse
@Aariq
Copy link
Collaborator

Aariq commented Nov 3, 2023

I don't think these errors with xfun::isFALSE() are anything in PEcAn—the error is more likely coming from an old version of rmarkdown or knittr or something (not exactly sure, because Yihui doesn't really say where exactly the error comes from in his blog post). When I've seen this error, I've been able to fix it just by using recent versions of packages. For example, the vignettes for PEcAn.DB are built without error here: https://github.com/Aariq/PEcAn.DB/actions/runs/6641355603/job/18043682007#step:6:42. The vignettes also build locally just fine without throwing this error (if you have reasonably up-to-date packages, I guess).

@mdietze mdietze enabled auto-merge November 3, 2023 18:02
@infotroph
Copy link
Member

Closing since dropping support for R 4.0 seems to have ~fixed this.

@infotroph infotroph closed this Jan 28, 2024
auto-merge was automatically disabled January 28, 2024 08:14

Pull request was closed

@infotroph infotroph deleted the mdietze-patch-3 branch May 10, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants