Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] dollying when open the console , make crash #15

Open
liangyuqi opened this issue Jun 18, 2021 · 2 comments
Open

[Bug] dollying when open the console , make crash #15

liangyuqi opened this issue Jun 18, 2021 · 2 comments

Comments

@liangyuqi
Copy link

liangyuqi commented Jun 18, 2021

hi, i'm sorry I'm not a native speaker of English

To Reproduce

Steps to reproduce the behavior:

  1. visit the demo, https://paulhax.github.io/spin-controls/
  2. open the console
  3. zoomIn && zoomOut 10 times quickly
  4. looks like crash

Live example

zoom factor become less and less , looks like crash
test3

but when i close the console, it works well
test1

Expected behavior
dollying has smoother animation when i open the console

Platform:

  • Device: [Desktop]
  • OS: [MacOS]
  • Browser: [Chrome]
  • Three.js version: [124?]
@liangyuqi liangyuqi changed the title [Bug] dollying when open the console , make carsh [Bug] dollying when open the console , make crash Jun 18, 2021
@Yty202020
Copy link

hi 同修 加个节流会不会好点

@PaulHax
Copy link
Owner

PaulHax commented Jun 19, 2021

Looks like the trackball/target position gets set too close, so zoom/dolly changes very little. I'm not sure why. Perhaps has to do with order of events before index.html calls controls.setTargetPosition

Thank you for the detailed issue writeup! If you happen to establish mouse event level reproduction step , that could be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants