Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tag selector in case title has a space in #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexjbest
Copy link

In https://github.com/PatrickMassot/leanblueprint/blob/master/leanblueprint/templates/dep_graph.html#L137 the code

           $('#'+title.replace(':', '\\:')+'_modal').show().children().show().children().show();

is used to select elements with a given id, this id is generated from the labels in the tex source, and this fails to select the element if this label contains spaces.
We hit this issue in leanprover-community/flt-regular as the blueprint was converted from some pre-existing notes where the labels did have spaces in.
Following https://stackoverflow.com/questions/596314/jquery-ids-with-spaces we change the selector to allow spaces in the id.

I haven't been able to test this change yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant