RE: alextowle Audit #2 Change

[iainnash]

2. Check for Zora Auction Currency

There is no check to ensure that Zora auctions are settled in ETH. User funds do not appear to be at risk as the Zora AuctionHouse contract will revert if the specified bid amount is not provided in the target currency. This said, PartyBid instances that target Zora auctions that aren’t settled in ether are a waste of time for PartyBid users.

To prevent such instances from being created by the PartyBidFactory, a check can be made in the ZoraMarketWrapper’s auctionIdMatchesToken function that the auction’s currency is ether (address 0).

Looking at this suggested implementation, renaming auctionIdMatchesToken as validAuctionIdForToken may make sense since this additional check is included here.

[anna-carroll]

I totally agree with this. I considered when making the change, but at the time just wanted to limit any code changes

[iainnash]

Makes sense!

…

On Thu, Jul 15, 2021 at 08:07 Anna Carroll ***@***.***> wrote: I totally agree with this. I considered when making the change, but at the time just wanted to limit any code changes — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMCOARQRBZSQF7C5J4NP3TX3FQXANCNFSM5AHK4IMQ> .