Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract options functionality to a new class #2620

Open
acicovic opened this issue Jul 9, 2024 · 0 comments
Open

Extract options functionality to a new class #2620

acicovic opened this issue Jul 9, 2024 · 0 comments
Labels
Type: Maintenance Type: Refactoring Items that result directly or indirectly in refactoring
Milestone

Comments

@acicovic
Copy link
Collaborator

acicovic commented Jul 9, 2024

Is your feature request related to a problem?

Most if not all of our options core functionality is within the Parsely class, which is a kind of catch-all class that has been growing lately.

Describe the solution you'd like

Extract the options functionality to a dedicated Options (or similarly named) class. While we are at it, we can consider:

  • Making some functions static.
  • Replacing the options array with a typed object in the code. The object could still be saved as an array into the database. We currently use phpstan types for checking the correctness of this array, but this isn't without its shortcomings.

Even the simple scenario of just moving functionality outside of the Parsely class might need changes in many other places.

@acicovic acicovic added this to the Summer 2024 milestone Jul 9, 2024
@acicovic acicovic added Type: Maintenance Type: Refactoring Items that result directly or indirectly in refactoring labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Refactoring Items that result directly or indirectly in refactoring
Projects
None yet
Development

No branches or pull requests

1 participant