Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

다크 모드 설정 지원 요청 (Request support for setting up dark mode) #138

Open
hsrjmk opened this issue Jul 16, 2024 · 0 comments

Comments

@hsrjmk
Copy link

hsrjmk commented Jul 16, 2024

안녕하세요, 먼저 TedImagePicker 라이브러리에 감사 드립니다.

현재 안드로이드 시스템 설정 > 디스플레이 다크 모드를 다크로 설정 시 여전히 라이트로 표시가 되는 이슈가 있습니다.

README 파일을 참고하여 TedImagePicker의 테마 설정 (styles.xml) 을 변경해 봤지만
일부 레이아웃에는 하드 코딩(@color/white, @color/black 등) 된 색상 값이 있어
배경, 메뉴 아이콘 및 텍스트 색상을 커스터마이징 하는데 제약이 있는 것 같습니다.

다크 모드를 지원할 수 있도록 수정 요청 드리며, 혹시 다른 방법이 있으면 자세히 알려주시면 좋겠습니다.

예시) tedimagepicker/src/main/res/layout/activity_ted_image_picker.xml 중 일부 발췌


Hello, first of all, thank you for the TedImagePicker library.

Currently, there is an issue where the Android system settings > display dark mode is still displayed as light when set to dark.

I tried changing the theme settings (styles.xml) of TedImagePicker by referring to the README file.
Some layouts have hard-coded color values ​​(@color/white, @color/black, etc.)
There seem to be limitations in customizing the background, menu icon, and text color.

We would like to request modifications to support dark mode. If there is another method, please let us know in detail.

Example) Excerpt from tedimagepicker/src/main/res/layout/activity_ted_image_picker.xml

<androidx.drawerlayout.widget.DrawerLayout
        android:id="@+id/drawer_layout"
        android:layout_width="0dp"
        android:layout_height="0dp"
        app:layout_constraintBottom_toTopOf="@id/view_bottom"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHorizontal_bias="0"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent">

        <include
                android:id="@+id/layout_content"
                layout="@layout/layout_ted_image_picker_content" />

                <androidx.recyclerview.widget.RecyclerView
                        android:id="@+id/rv_album"
                        android:layout_width="wrap_content"
                        android:layout_height="match_parent"
                        android:layout_gravity="start"
                        android:background="@color/white"
                        android:overScrollMode="never"
                        app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
                        tools:listitem="@layout/item_album" />
</androidx.drawerlayout.widget.DrawerLayout>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant