You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are many versions of Allen-Cahn implemented in pySDC. Mostly, they solve the same equation, but differ only in dimensionality or the solver. However, there are some subtle differences that can lead to bugs. Comparing for instance the 2D FD and 2D MPIFFT implementations, we find the FD version has a grid [-0.5, 0.5]^2 and the MPIFFT version has a grid [0, 1]^2. Also, the FD version has phases $\pm 0.5$, with the other one having phases $0$ and $1$. I noticed this when trying to use a hook for computing the radius designed for the FD version on the FFT one.
Are there any reasons for these discrepancies? Do they matter in practice? If not, I suggest we streamline this at some point.
Also, we can unify the GPU and CPU versions of the FD implementation and change to the work counters there in the process.
The text was updated successfully, but these errors were encountered:
So, there is no (good) reason for this discrepancy. We started somewhere and changed the way we did things over time. This is rather unfortunate and quite a few people stumbled across this problem. It would be good to homogenize this at some point, indeed.
There are many versions of Allen-Cahn implemented in pySDC. Mostly, they solve the same equation, but differ only in dimensionality or the solver. However, there are some subtle differences that can lead to bugs. Comparing for instance the 2D FD and 2D MPIFFT implementations, we find the FD version has a grid [-0.5, 0.5]^2 and the MPIFFT version has a grid [0, 1]^2. Also, the FD version has phases$\pm 0.5$ , with the other one having phases $0$ and $1$ . I noticed this when trying to use a hook for computing the radius designed for the FD version on the FFT one.
Are there any reasons for these discrepancies? Do they matter in practice? If not, I suggest we streamline this at some point.
Also, we can unify the GPU and CPU versions of the FD implementation and change to the work counters there in the process.
The text was updated successfully, but these errors were encountered: