Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Allen-Cahn problems #434

Open
brownbaerchen opened this issue May 22, 2024 · 1 comment
Open

Inconsistent Allen-Cahn problems #434

brownbaerchen opened this issue May 22, 2024 · 1 comment
Labels
good first issue If you want to start developping pySDC, this is a good place to start

Comments

@brownbaerchen
Copy link
Contributor

There are many versions of Allen-Cahn implemented in pySDC. Mostly, they solve the same equation, but differ only in dimensionality or the solver. However, there are some subtle differences that can lead to bugs. Comparing for instance the 2D FD and 2D MPIFFT implementations, we find the FD version has a grid [-0.5, 0.5]^2 and the MPIFFT version has a grid [0, 1]^2. Also, the FD version has phases $\pm 0.5$, with the other one having phases $0$ and $1$. I noticed this when trying to use a hook for computing the radius designed for the FD version on the FFT one.

Are there any reasons for these discrepancies? Do they matter in practice? If not, I suggest we streamline this at some point.

Also, we can unify the GPU and CPU versions of the FD implementation and change to the work counters there in the process.

@brownbaerchen brownbaerchen added the good first issue If you want to start developping pySDC, this is a good place to start label May 22, 2024
@pancetta
Copy link
Member

So, there is no (good) reason for this discrepancy. We started somewhere and changed the way we did things over time. This is rather unfortunate and quite a few people stumbled across this problem. It would be good to homogenize this at some point, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue If you want to start developping pySDC, this is a good place to start
Projects
None yet
Development

No branches or pull requests

2 participants