Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LOG(FATAL) and CHECK in Paddle #855

Closed
jacquesqiao opened this issue Dec 13, 2016 · 1 comment
Closed

Remove LOG(FATAL) and CHECK in Paddle #855

jacquesqiao opened this issue Dec 13, 2016 · 1 comment
Assignees
@jacquesqiao

Comments

@jacquesqiao
Copy link
Member

jacquesqiao commented Dec 13, 2016 •
edited
Loading

This issue is used to remove all LOG(FATAL) and CHECK in paddle. Related issue #849 .
Paddle was used as a command line tool in the past, so it should crash if any problems ware found. But if we want to use Paddle as lib in notebook, error should been thrown as exception but not crash.
@jacquesqiao jacquesqiao self-assigned this Dec 13, 2016
@jacquesqiao jacquesqiao changed the title Remove LOG(FATAL) and CHCEK in Paddle Remove LOG(FATAL) and CHECK in Paddle Dec 13, 2016
@reyoung
Copy link
Collaborator

reyoung commented Jul 20, 2017

Now we are refactoring Paddle and using PADDLE_ENFORCE to fix this.

@reyoung reyoung closed this as completed Jul 20, 2017
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this issue Sep 25, 2019
@shanyi15
Update FAQ (PaddlePaddle#855)
91d6762 
* update_faq

* revise the style

* modify the FAQ format
yaozhixin pushed a commit to graphcore/Paddle-fork that referenced this issue Jul 1, 2022
@gglin001
Fix cmake ci (PaddlePaddle#855)
2f98904 
* fix cmake CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacquesqiao jacquesqiao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reyoung @jacquesqiao