Create data util submodule for bbn things, util for frame extraction, coco file #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class VideoInfo: | ||
| truth_path: Path | ||
| mp4_path: Path | ||
| frames_dir: Path = dataclasses.field(init=False) |
There was a problem hiding this comment.
This is a very picky review item: do we have a differentiation between _path and _dir?
There was a problem hiding this comment.
"Path" seems generic to me - I'm not sure if I'm looking at a filepath or a path to a directory or a Path object that could be either?
There was a problem hiding this comment.
Fair, I can rename the paths intended for files to be _file instead of a generic _path
Purg
force-pushed
the
dev/bbn-coco-script
branch
from
c9c52a4 to
ebdd662
Compare
josephvanpeltkw
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tooling for creating an activity classification truth COCO file. Includes frame extraction standardization and improving the BBN truth file parsing with regular expressions, handling an additional aspect of per-step error labels.