Skip to content

Commit

Permalink
add todo's for PR things I'm not getting to yet.
Browse files Browse the repository at this point in the history
  • Loading branch information
cameron-a-johnson committed Nov 6, 2024
1 parent e137021 commit 202f9aa
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tcn_hpl/data/vectorize/locs_and_confs.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ def vectorize(self, data: FrameData) -> npt.NDArray[np.float32]:

vector_len = self.determine_vector_length(data)
frame_feat = np.zeros(vector_len, dtype=np.float32)
# TODO: instead of carrying around this vector_ind, we should
# directly compute the offset of each feature we add to the TCN
# input vector. This would be much easier to debug.
vector_ind = 0
if self._use_pixel_norm:
W = data.size[0]
Expand All @@ -109,6 +112,7 @@ def vectorize(self, data: FrameData) -> npt.NDArray[np.float32]:

# Loop through all classes: populate obj conf, obj X, obj Y.
# Assumption: class labels are [0, 1, 2,... num_classes-1].
# TODO: this will break if top_k is ever > 1. Fix that.
for obj_ind in range(0,self._num_classes):
top_k_idxs = self.get_top_k_indexes_of_one_obj_type(f_dets, self._top_k, obj_ind)
if top_k_idxs: # This is None if there were no detections to sort for this class
Expand Down

0 comments on commit 202f9aa

Please sign in to comment.