Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass arguments to test binary from flit make #240

Open
jjgarzella opened this issue Nov 20, 2018 · 1 comment
Open

Pass arguments to test binary from flit make #240

jjgarzella opened this issue Nov 20, 2018 · 1 comment
Labels
documentation Involves touching documentation enhancement make Involves touching GNU Makefiles python Involves touching python code tests Involves touching tests

Comments

@jjgarzella
Copy link
Contributor

Feature Request

Describe the new feature:
Right now, if I run flit make, it runs each test in its default configuration, running all precisions and timing tests. However, for certain cases (e.g. preliminary tests), I would like to only run a single precision, and not have to use timing tests. Currently, I have to do this manually.

Suggested change:
Add an option similar to --make-args, possibly called --test-args, which forwards arguments to the test binaries.

Alternative approaches:
Doing it manually is a workaround, but it takes a little time to figure out how to do it right.

@mikebentley15
Copy link
Collaborator

If you do not want to run with timing, you can turn off the timing in flit-config.toml. As for which precisions to run and such, I think it would be good to give a flag. I would probably add similar flags to flit make that the test executables have, such as --precision and others. For the implementation within the Makefile, I think we can make use of environment variables or Make variables to communicate this intent.

Thanks for this feedback JJ

@mikebentley15 mikebentley15 added bug python Involves touching python code make Involves touching GNU Makefiles tests Involves touching tests documentation Involves touching documentation enhancement and removed bug labels Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Involves touching documentation enhancement make Involves touching GNU Makefiles python Involves touching python code tests Involves touching tests
Projects
None yet
Development

No branches or pull requests

2 participants