Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting is incorrect with # in an alias name #560

Open
richb-hanover opened this issue Jul 13, 2024 · 1 comment
Open

Syntax highlighting is incorrect with # in an alias name #560

richb-hanover opened this issue Jul 13, 2024 · 1 comment

Comments

@richb-hanover
Copy link
Contributor

Creating an alias that contains a "#" gives an incorrect coloring in the VSCode Extension. The generated SQL is OK. Using the example below:

from albums
derive `foo#` = 5

In the Playground, the syntax coloring looks OK and the SQL is too.

In the VSCode Extension, the SQL is OK, but the highlighting shows the "#` = 5" to be grey and italicized.

image

Moved here from: PRQL/prql#4725

@richb-hanover richb-hanover changed the title Syntax highlighting with # in an alias name is incorrect... Syntax highlighting is incorrect with # in an alias name Jul 13, 2024
@max-sixty
Copy link
Member

max-sixty commented Jul 13, 2024

This would be great to fix. It's probably not a trivial fix given the code grammar is in TextMate, but also not impossible — rust does manage:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants