Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet closes unexpectedly when sending shielded to transparent address #2729

Open
SiggeBas opened this issue Jan 21, 2022 · 2 comments
Open

Comments

@SiggeBas
Copy link

This issue tracker is only for technical issues related to PIVX Core.
General PIVX questions and/or support requests and are best directed to the PIVX Discord.

Describe the issue

Tried to send from two shielded addresses (via coin selector) to a transparent address. After typing in the password, the wallet closes without any message/warning.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. Paste the transparent receiver address, chose from shielded coin selector
  2. Press 'send' button, type wallet password
  3. Press SEND button, wallet closes. End

Expected behavior

The wallet should remain open, show 'preparing transaction', and go back to Send screen.
This doesn't happen when I send from transparent to transparent

Actual behavior

Wallet closes unexpectedly

Screenshots.

If the issue is related to the GUI, screenshots can be added to this issue via drag & drop.

What version of PIVX Core are you using?

List the version number/commit ID, and if it is an official binary, self compiled or a distribution package.
Official binary via snap, v5.4.0

Machine specs:

  • OS: Ubuntu
  • CPU: Intel® Core™ i5-7200U CPU @ 2.50GHz × 4
  • RAM: 12
  • Disk size: 1TB
  • Disk Type (HD/SDD): SSD

Any extra information that might be useful in the debugging process.

This is normally the contents of a debug.log, db.log or config.log file. Raw text or a link to a pastebin type site are preferred.

@SiggeBas
Copy link
Author

It seems like this issue doesn't happen if i DO NOT use coin control. Every time I use coin control to determine from which shielded addresses the coins should be taken to be unshielded, the wallet closes.

@furszy
Copy link

furszy commented Jan 22, 2022

A possible "one-fit-all" solution would be to start the node with the following flag: -zapwallettxes=2. It will drop the wallet's transactions metadata and rescan the chain.

Aside from that, please upload your debug.log file here or send it to me via DM, so the problem cause can be investigated.

panleone pushed a commit to panleone/PIVX that referenced this issue Oct 29, 2024
…esManager (PIVX-Project#2729)

* Return bool in ProcessMessageXXX methods to indicate misbehaviour

* Send/Receive multiple messages as part of one P2P message in CSigSharesManager

Many messages, especially QSIGSHARESINV and QGETSIGSHARES, are very small
by nature (5-14 bytes for a 50 members LLMQ). The message headers are
24 bytes, meaning that we produce a lot of overhead for these small messages.
This sums up quite a bit when thousands of signing sessions are happening
in parallel.

This commit changes all related P2P messages to send a vector of messages
instead of a single message.

* Remove bogus lines

Included these by accident

* Unify handling of BanNode in ProcessMessageXXX methods

* Remove bogus check for fMasternodeMode

* Properly use == instead of misleading >= in SendMessages

* Put "didSend = true" near PushMessage
Fuzzbawls added a commit that referenced this issue Nov 5, 2024
a29d294 Fix deadlock in CSigSharesManager::SendMessages (#2757) (Alexander Block)
b4a4e09 Ignore sig share inv messages when we don't have the quorum vvec (#2733) (Alexander Block)
a2fb276 On timeout, print members proTxHashes from members which did not send a share (#2731) (Alexander Block)
d1084e0 Actually start the timers for sig share and recSig verification (#2730) (Alexander Block)
71092e0 Send/Receive multiple messages as part of one P2P message in CSigSharesManager (#2729) (Alexander Block)
e73c238 Merge pull request #2726 from codablock/pr_llmq_sessionids (UdjinM6)
7ccd790 Merge pull request #2725 from codablock/pr_llmq_hashmaps (Alexander Block)
a0084f5 Multiple fixes and optimizations for LLMQs and ChainLocks (#2724) (Alexander Block)
0613978 Cleanup successful sessions before doing timeout check (#2712) (Alexander Block)
c9127e1 Avoid using ordered maps in LLMQ signing code (#2708) (Alexander Block)

Pull request description:

  Follow up of #2921

  each commit backports a PR. you can find the number of the PR in the commit description

ACKs for top commit: a29d294
  Duddino:
    utACK a29d294
  Fuzzbawls:
    utACK a29d294

Tree-SHA512: 75483d543f39d85a2924606b1f7c359a45a52e0ebd84bdc06275080db2d07aa657d692461fbf22d23890d3a0394ebffae0c662a2def420d53ebcdb69c974ba6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants