GH Actions: show deprecations when linting & lint against next PHP version #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While rare, there are some deprecations which PHP can show when a file is being linted. By default these are ignored by PHP-Parallel-Lint. Apparently though, there is an option to show them (wasn't documented until recently), so let's turn that option on.
The PHP lint job currently checks all PHP files for parse/compile errors against a limited set of PHP versions, including the high/low versions. It did not run the linter against the _next_ (upcoming) PHP version yet. This has now been added with the `'nightly'` alias, which means that the version will automatically roll through to the next PHP version when a new PHP branchs gets cut, without us needing to manually maintain this. Also note that the build against `nightly` is allowed to fail.
jrfnl
force-pushed
the
feature/ghactions-show-compile-time-deprecations
branch
from
76b58de to
14f8798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
GH Actions: show deprecations when linting
While rare, there are some deprecations which PHP can show when a file is being linted.
By default these are ignored by PHP-Parallel-Lint.
Apparently though, there is an option to show them (wasn't documented until recently), so let's turn that option on.
GH Actions: also lint against next PHP version
The PHP lint job currently checks all PHP files for parse/compile errors against a limited set of PHP versions, including the high/low versions.
It did not run the linter against the next (upcoming) PHP version yet.
This has now been added with the
'nightly'alias, which means that the version will automatically roll through to the next PHP version when a new PHP branchs gets cut, without us needing to manually maintain this.Also note that the build against
nightlyis allowed to fail.