Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions/test: PHP 8.3 has been released #212

Merged
merged 1 commit into from
Dec 3, 2023
Merged

GH Actions/test: PHP 8.3 has been released #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/integrationtest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
- '8.1'
- '8.2'
- '8.3'
- '8.4'
composer:
- 'v1'
- 'v2'
Expand Down Expand Up @@ -79,6 +80,9 @@ jobs:
- php: '8.3'
composer: '2.2'
os: 'ubuntu-latest'
- php: '8.4'
composer: '2.2'
os: 'ubuntu-latest'

- php: '7.2'
composer: '2.2'
Expand All @@ -101,6 +105,9 @@ jobs:
- php: '8.3'
composer: '2.2'
os: 'windows-latest'
- php: '8.4'
composer: '2.2'
os: 'windows-latest'

# Also test against the dev version of Composer for early warning about upcoming changes.
- php: 'latest'
Expand All @@ -113,7 +120,7 @@ jobs:

name: "Integration test"

continue-on-error: ${{ matrix.php == '8.3' || matrix.composer == 'snapshot' }}
continue-on-error: ${{ matrix.php == '8.4' || matrix.composer == 'snapshot' }}

steps:
- name: Checkout code
Expand All @@ -133,15 +140,15 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-php-dependencies-with-composer
- name: Install Composer dependencies
if: ${{ matrix.php != '8.3' }}
if: ${{ matrix.php != '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: '--optimize-autoloader'
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

- name: Install Composer dependencies
if: ${{ matrix.php == '8.3' }}
if: ${{ matrix.php == '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: '--ignore-platform-reqs --optimize-autoloader'
Expand Down
5 changes: 3 additions & 2 deletions tests/PHPCSVersions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,10 @@ function ($version) {
break;

case '8.3':
case '8.4':
/*
* At this point in time, it is unclear as of which PHPCS version PHP 8.2 will be supported.
* In other words: tests should only use dev-master/4.x when on PHP 8.2 for the time being.
* At this point in time, it is unclear as of which PHPCS version PHP 8.3/8.4 will be supported.
* In other words: tests should only use dev-master/4.x when on PHP 8.3/8.4 for the time being.
*/
$versions = array();
break;
Expand Down