Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions/test: PHP 8.3 has been released #212

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 26, 2023

Proposed Changes

  • Builds against PHP 8.3 are no longer allowed to fail.
  • Add allowed to fail build against PHP 8.4.

I'm opening this in draft until one of us finds some time to figure out why the tests aren't running properly anymore and fixes that first. PR #213 should fix the failing build. Once that PR has been merged, this one can be rebased & the build should pass.

Related Issues

@jrfnl jrfnl force-pushed the feature/ghactions-php-8.3-release branch from 3f5bbba to 4837488 Compare November 26, 2023 03:03
@jrfnl
Copy link
Member Author

jrfnl commented Nov 26, 2023

Note: recommended to add PHP 8.3 to the branch protection as required builds.

Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

* Builds against PHP 8.3 are no longer allowed to fail.
* Add _allowed to fail_ build against PHP 8.4.
@jrfnl jrfnl force-pushed the feature/ghactions-php-8.3-release branch from 4837488 to e68f1ec Compare December 3, 2023 16:39
@jrfnl jrfnl added this to the 1.x Next Release milestone Dec 3, 2023
@jrfnl jrfnl marked this pull request as ready for review December 3, 2023 16:44
@jrfnl
Copy link
Member Author

jrfnl commented Dec 3, 2023

Rebased after the merge of #213 to get a (hopefully) passing build.

@jrfnl jrfnl merged commit 48a9d47 into main Dec 3, 2023
102 checks passed
@jrfnl jrfnl deleted the feature/ghactions-php-8.3-release branch December 3, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants