-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing the updating of CMIP6_CV.json #318
Comments
@durack1 The changes from last night were merged into the The cronjob is still running but pushes changes into the |
@mauzey1 perfect thanks! Also the CMIP6 Data Request 01.00.33 is now available, should I open a new issue for that? |
@durack1 Yes, please create an issue for the new data request. |
@mauzey1 was this implemented, if yes, I suggest you close |
This hasn't been implemented, yet. |
If it's trivial, would this be worth doing? To be honest I cannot see a huge amount of CMIP6_CVs changes happening, but I'm sure the changes will continue for another 6 months or so |
@mauzey1 I believe the cron is now managing this updating, so we should close - if this is the case, please do so next week |
Currently, CMIP6_CV.json is updated using a script that downloads JSON files from WCRP-CMIP/CMIP6_CVs. The script runs on a server on a daily basis, and commits changes to the
develop
branch of this repo. CircleCI tests will run to check the changes to thedevelop
branch, but they will need to be manually merged into themaster
branch.A recent running of the script ran into a bug where a blank CMIP6_CV.json was committed to the
develop
branch. This may have been due to the script running into a network issue when downloading the WCRP-CMIP/CMIP6_CVs JSON files while it had a blank CMIP6_CV.json open. I was able to rerun the script, unmodified, to produce a new CMIP6_CV.json.Here are some changes I would like to propose to solve these issues:
develop
intomaster
when all tests pass. This can be done in CircleCI by creating a job that requires both the Linux and OSX tests to pass before merging.The text was updated successfully, but these errors were encountered: