Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed top menu is created #65

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed top menu is created #65

wants to merge 5 commits into from

Conversation

iamajmalsaleem
Copy link

@iamajmalsaleem iamajmalsaleem commented Oct 23, 2021 •
edited by thatrobotdev
Loading

For Issue: #PLACE_ISSUE_NUMBER_HERE

Fixes:

Additions:

Checklist

  • Ensured there is an open issue for your PR
  • Added comments to additions
  • Followed common formatting conventions for the contribution language
  • Tested code to ensure original features are working

Select one:

  • Ensured you are the contributer assigned to the Issue for this PR
  • Commented for ownership of an OPEN issue where no one is assigned or has yet asked to be assigned

Screenshots

@thatrobotdev
Copy link
Contributor

thatrobotdev commented Oct 29, 2021 •
edited
Loading

Hello! Could you fill out your initial PR description with details about your changes?

iamajmalsaleem
iamajmalsaleem commented Oct 30, 2021
View reviewed changes
Copy link
Author

@iamajmalsaleem iamajmalsaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created Fixed Menu for the website

thatrobotdev
thatrobotdev requested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@thatrobotdev thatrobotdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying what you were changing, and thank you for your contribution! I think that a fixed navbar for the site would work really well!

It looks like in the way you implemented it, there are some spacing issues on the left and right of the navbar that didn't exist before. Could you implement a fixed navbar in a way that is visually identical to the old version, but fixed?

Thanks!

screenshot of website with annotated requested changes

@thatrobotdev thatrobotdev added the enhancement New feature or request label Nov 1, 2021
@thatrobotdev thatrobotdev linked an issue Nov 1, 2021 that may be closed by this pull request
Fix the navbar to the top of the screen, so that it stays as you scroll down #66
Open
@thatrobotdev thatrobotdev mentioned this pull request Nov 1, 2021
Open
@iamajmalsaleem
Copy link
Author

Thanks for assigning the issue. I'll try my best to fix it :)

@iamajmalsaleem
Update styles.css
acec34d 
Fixed bug in fixed-menu-bar
@iamajmalsaleem
Update index.html
fcbd74a 
Added  id="nav-bar"  for purpose of fixing bug on fixed-menu-bar
@iamajmalsaleem
Copy link
Author

Any changes ?

@iamajmalsaleem
Update index.html
34f216e 
Added break between NAVIGATION END and SLIDE SHOW START to adjust display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatrobotdev thatrobotdev Awaiting requested review from thatrobotdev

Assignees

@iamajmalsaleem iamajmalsaleem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the navbar to the top of the screen, so that it stays as you scroll down
2 participants
@iamajmalsaleem @thatrobotdev