Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate XML Schema for AS4 Receipts #135

Open
phax opened this issue Aug 31, 2020 · 4 comments
Open

Validate XML Schema for AS4 Receipts #135

phax opened this issue Aug 31, 2020 · 4 comments
Labels
bug Something isn't working issue Issue which are under review, can be bug
Milestone

Comments

@phax
Copy link

phax commented Aug 31, 2020

Hi guys,
It seems like you are not checking incoming AS4 Receipts against the XML Schema rules.
E.g. a MessagePartNRInformation element that contains both a MessagePartProperties and a ds:Reference element is accepted:
grafik

According to the XML schema this is a choice.
This leeds to non-standard behaviour in the Peppol Testbed.

Thanks and BR,
Philip o.b.o. OpenPEPPOL eDEC

@klakegg klakegg transferred this issue from OxalisCommunity/oxalis Aug 31, 2020
@FrodeBjerkholt FrodeBjerkholt added the enhancement New feature or request label Aug 31, 2020
@FrodeBjerkholt
Copy link
Contributor

I will add XML schema validation of the receipt.

@aaron-kumar aaron-kumar added bug Something isn't working Pri/L Low priority and removed enhancement New feature or request labels Jun 3, 2021
@aaron-kumar aaron-kumar added the issue Issue which are under review, can be bug label Dec 6, 2021
@aaron-kumar aaron-kumar added this to the 5.x.x milestone Dec 6, 2021
@aaron-kumar aaron-kumar moved this to Open Issues- Review Required in Oxalis Public Roadmap Dec 6, 2021
@aaron-kumar aaron-kumar removed the Pri/L Low priority label Jul 29, 2022
@phax
Copy link
Author

phax commented Oct 12, 2022

I don't understand why this gets low priority. Not validating the output may cause severe issues if the response is indeed invalid...

@aaron-kumar
Copy link
Member

@phax : We did Not lowered its priority but only removed label "Pri/L", part of task to cleanup unnecessary labels. It is still marked with Label "bug" and "issue".
I am working on schema validation and this will be fixed in upcoming release.

@phax
Copy link
Author

phax commented Oct 22, 2022

Thanks Arun - I this will bring some good improvement to the overall quality on the exchanged messages in the network :)

@aaron-kumar aaron-kumar modified the milestones: 5.x.x, 6.x.x Jan 16, 2023
@aaron-kumar aaron-kumar moved this from Open Issues- Review Required to Q1 2023 –Jan-March in Oxalis Public Roadmap Jan 16, 2023
@aaron-kumar aaron-kumar moved this from Q2 2023 – April-June to Q4 2023 – October-December in Oxalis Public Roadmap Sep 25, 2023
@aaron-kumar aaron-kumar moved this from Q4 2023 – October-December to Future in Oxalis Public Roadmap Dec 9, 2023
@aaron-kumar aaron-kumar modified the milestones: 6.x.x, 7.x.x Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issue Issue which are under review, can be bug
Projects
Status: Future
Development

No branches or pull requests

3 participants