Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM v6 is coming soon #58

Closed
JaffaKetchup opened this issue Oct 4, 2023 · 8 comments · Fixed by #60
Closed

FM v6 is coming soon #58

JaffaKetchup opened this issue Oct 4, 2023 · 8 comments · Fixed by #60

Comments

@JaffaKetchup
Copy link
Contributor

The next version of flutter_map is coming soon, with breaking changes for all users and plugins!

Expected CHANGELOG: https://github.com/fleaflet/flutter_map/blob/release-prep/CHANGELOG.md
Likely to be merged PR with significant impacts: fleaflet/flutter_map#1615
Release prep PR: fleaflet/flutter_map#1632
New documentation (path liable to change): https://docs.fleaflet.dev/v/v6-1
Expected migration instructions, suitable for most users: https://docs.fleaflet.dev/v/v6-1/getting-started/migrating-to-v6
List of commits since v5 (more to come): fleaflet/flutter_map@v5.0.0...master

@Mike-3
Copy link

Mike-3 commented Oct 13, 2023

V6 is released

@JaffaKetchup
Copy link
Contributor Author

JaffaKetchup commented Oct 16, 2023

Hey @HugoHeneault (I think you're maintaining this),

We (the FM team) were wondering if you are still planning to maintain this repository? The last commit was a while ago, and we've had a PR submitted to the FM repo to improve some rough edges: see #59 & #56 here, and fleaflet/flutter_map#1685 & fleaflet/flutter_map#1686.

The PR on the FM repo still isn't confirmed or merged yet, as we want to make sure that this repo is actually abandoned before absorbing it. If you (or anyone else) is still planning to maintain this, we'll hold off.

We'd be extremely grateful for a response, and no worries if you're too busy or have just moved on :)

@HugoHeneault
Copy link
Contributor

HugoHeneault commented Oct 17, 2023

Hey @JaffaKetchup :)

Thanks for asking, really appreciate it :)
I'll do my best to merge it this week.

Quite busy here, still want to maintain the plugin but if things accumulate too much it might be better to merge everything in the main FM repo.
I'd say it's also an FM team decision: do you prefer codebase to grow and have have hands on more responsibility but also keep everything synced (better dx for FM users) or let each maintainer/team handle plugins updates?

@JaffaKetchup
Copy link
Contributor Author

JaffaKetchup commented Oct 17, 2023

@HugoHeneault Ok, for now, we'll try to keep things here. It's a possibility that this could now be handled by us, but this was made before that was reasonable, and therefore, we don't want to absorb a plugin with a maintainer who's still active!

I've asked @thomascoumau, the author of #56 and fleaflet/flutter_map#1686, to resubmit his PR here (I don't think #56 is quite up to date with all the changes he wants to make), so hopefully that'll work.

@HugoHeneault
Copy link
Contributor

Great! @JaffaKetchup I'm finishing v6 migration, and it seems that TapPosition isn't exported anymore.

I still need it, do I have to craft a PR on FM repo?

@JaffaKetchup
Copy link
Contributor Author

Hmm, I'll need to track that down and open a PR - I guess I forgot to export it after getting rid of the Plugin API import. I'll have some time in about an hour so I can do it then, or feel free to do it now.

@JaffaKetchup
Copy link
Contributor Author

Actually @HugoHeneault, something may have just changed, so I'll hold on for a minute.

Do you think you could join the FM Discord and let me know your username?

@HugoHeneault
Copy link
Contributor

I've joined the server and asked you as a friend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants