Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Plus/Minus button to increment chapter count from the HomePage #30

Open
OverPoweredDev opened this issue Oct 23, 2021 · 5 comments
Labels
Enhancement New feature or request Help Wanted Extra attention is needed

Comments

@OverPoweredDev
Copy link
Owner

Submitter: Willshaper
After clicking a novel in the list, a plus and minus button to edit chapter numbers easily (without having to type out the number in update details) would be nice to have.

@OverPoweredDev OverPoweredDev added Bug Something isn't working Enhancement New feature or request Help Wanted Extra attention is needed labels Oct 23, 2021
@OverPoweredDev
Copy link
Owner Author

While implementing that isn't hard, I'm only concerned with where to put these so it looks good on the layout. Any suggestions on that are much appreciated

@OverPoweredDev OverPoweredDev removed the Bug Something isn't working label Oct 24, 2021
@Willshaper
Copy link

That is indeed a good question.

I have played around a bit in Paint, but found it hard to find good locations for it.

Here's 3 different options i tried out.

FIrst one has the button added under the expanded menu, and the two others are + and - buttons on the normal non-expanded layout.

Personally out of these options i like the first option the most. It keeps the clean look of the app, but still allows easy access to add a chapter by expanding the menu first.

https://i.imgur.com/2cpTi94.png

@OverPoweredDev
Copy link
Owner Author

To be honest, there's a few implementation details that make the screencaps you sent not possible (Mainly that the NovelCard component only accepts text and changing that would fuck up a lot of things). That said, the main point is just to increment the chapter by a few amounts without going to the details page.

And now that I think about it, it's very rare that you'd go back a chapter, right? So we can just remove the - altogether and add a small + button similar to the Update Details button right above it.

@OverPoweredDev
Copy link
Owner Author

I'm a bit busy because of exams and all so can't pick it up immediately. But I can have it added as an optional feature by 1.4.0 (next update) along with reading lists and dynamic links (#25)

@OverPoweredDev OverPoweredDev changed the title Issue from User on GitReports Add a Plus/Minus button to increment chapter count from the HomePage Nov 7, 2021
@OverPoweredDev
Copy link
Owner Author

OverPoweredDev commented Dec 4, 2021

This might take a while to implement so I'll have this scheduled for 1.4.1.

I wanna release 1.4.0 asap, it's been a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants