Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improved FT/NFT management for COA accounts on EVM on Flow #78

Open
6 tasks
JeffreyDoyle opened this issue Nov 22, 2024 · 0 comments
Open
6 tasks
Labels
enhancement New feature or request

Comments

@JeffreyDoyle
Copy link
Collaborator

JeffreyDoyle commented Nov 22, 2024

Feature

For COA accounts on EVM on Flow, Flow Wallet enables users to add custom fungible tokens to watch by supplying the token's contract address to Flow Wallet.

However, with tools like SimpleHash (which Flow Wallet already supports), Flow Wallet can detect token ownership across all fungible tokens on EVM on Flow. This means, Flow Wallet can use this information about which tokens the user owns to help users in the process of adding new fungible tokens to watch.

Improved add FT/NFT view for COA accounts on EVM on Flow

All tokens can have two states, either "watched" or "hidden". Tokens are classified in three categories:

  • Tokens that are included in Flow Wallet's token list can be classified as "default" tokens.
  • Tokens that are detected by SimpleHash and are not "default" tokens can be classified as "detected" tokens.
  • Tokens that have been imported by the user as a custom token, regardless if they're classified as "default" or "detected", are classified as "custom" tokens.

Tokens from the three categories can be either "watched" or "hidden", except for FLOW, STFLOW and USDC.e which must always be "watched".

Any default tokens must classified as "watched", and, therefore displayed in the FT/NFT list, provided they have had a non-zero balance at least once, except for FLOW, STFLOW and USDC.e, which cannot be "hidden" at any time, even if the user has never had a non-zero balance of these tokens.

All detected tokens must be initially classified as "hidden", until the user elects to watch those tokens.

Tokens displayed in the FT/NFT list in the app must be only tokens that are "watched".

When the user goes to add a new token to watch, we must display a new UI that enables the user to manage which tokens they're watching in the app. This UI should group tokens by "All" / "Watching" / "Hidden" / "Custom", and display tokens within each group as a row entry within a column representing the group.

Users should have the option to "hide" each token by selecting a button beside each asset, except for FLOW, STFLOW and USDC.e. When a token moves from watched to hidden, it moves between the watching and hidden groups. If the user is viewing the "all" group, all tokens, regardless if they're watched or hidden must be visible. Only tokens that have been added as a custom token must be displayed in the "custom" group. Tokens that were added as a custom token must be labelled as such.

Expected Outcomes

  • Designs complete
  • iOS implementation complete
  • Android implementation complete

Platforms

  • iOS
  • Android
  • Extension
@JeffreyDoyle JeffreyDoyle added the enhancement New feature or request label Nov 22, 2024
@JeffreyDoyle JeffreyDoyle moved this to Todo in Flow Wallet Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant