Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issue moving tokens (eg: st.FLOW and USDC.e) between Cadence / EVM at max precision #73

Open
4 tasks
JeffreyDoyle opened this issue Nov 17, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@JeffreyDoyle
Copy link
Collaborator

JeffreyDoyle commented Nov 17, 2024

Current Behavior

  • Users are reporting issues moving st.FLOW from their COA account to their Cadence account in Flow Wallet. The issue isn't happening when attempting to send these tokens between the accounts, but does happen when using our move feature. The issue comes up when attempting to move using greater precision (number of decimal places) than is supported.

Expected Behavior

  • Users are able to move st.FLOW / USDC.e (and any other token) between their COA and their Cadence account in Flow Wallet, using the maximum supported precision.

Steps to Reproduce

  • Acquire some st.FLOW in a COA in Flow Wallet
  • Attempt to move that st.FLOW to your Cadence account using the maximum supported precision.
  • Observe the transaction error.

Expected Outcomes

  • Users are able to move st.FLOW / USDC.e (and any other token) between their COA and their Cadence account in Flow Wallet, using the maximum supported precision.

Platforms

  • Extension
  • iOS (Reported on iOS, but let's verify all platforms)
  • Android

Details:

@JeffreyDoyle JeffreyDoyle added the bug Something isn't working label Nov 17, 2024
@JeffreyDoyle JeffreyDoyle moved this to Todo in Flow Wallet Nov 17, 2024
@JeffreyDoyle
Copy link
Collaborator Author

@Peppermint1020 - This occurs when inputting more than the supported decimal places for the amount of token to move. We need to ensure we properly round the amount to the correct precision.

@JeffreyDoyle JeffreyDoyle changed the title [BUG] Issue moving st.FLOW from EVM COA to Cadence account [BUG] Issue moving tokens (eg: st.FLOW and USDC.e) between Cadence / EVM at max precision Nov 21, 2024
@Peppermint1020
Copy link
Collaborator

Peppermint1020 commented Nov 21, 2024

Reproduced this issue in iOS prod version 2.2.10(10).
Succeed in : (1) move stFlow from Flow account to EVM account
(2) move stFlow from EVM account to Flow account
(3) move USDCE from Flow account to EVM account
Failed : (1) move USDCE from EVM account to Flow account
tx id: https://www.flowscan.io/tx/2197250b0862f74b70d27bdf8c9d16d81581f05bd6bb88ca81cfb03268a7e9b8

Updated fixed above issue in IOS prod version 2.2.11

@Peppermint1020
Copy link
Collaborator

Tested on extension prod 2.5.20.
Succeed in : (1) move stFlow from Flow account to EVM account
(2) move stFlow from EVM account to Flow account
(3) move USDCE from Flow account to EVM account
(4) move USDCE from EVM account to Flow account

@zhouxl zhouxl removed their assignment Nov 22, 2024
@zhouxl zhouxl moved this from Todo to Ready for QA in Flow Wallet Nov 22, 2024
@Peppermint1020
Copy link
Collaborator

Peppermint1020 commented Nov 26, 2024

Tested Android prod version i1.6.14.
Succeed in : (1) move stFlow from Flow account to EVM account
(2) move stFlow from EVM account to Flow account
(3) move USDCE from Flow account to EVM account
(4) move USDCE from EVM account to Flow account

@Peppermint1020 Peppermint1020 moved this from Ready for QA to Done in Flow Wallet Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants