Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Lockout before deallocation #23

Open
Others opened this issue Jun 5, 2020 · 0 comments
Open

Check Lockout before deallocation #23

Others opened this issue Jun 5, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed T-enhancement New feature or request T-ergonomics Something code be easier to use

Comments

@Others
Copy link
Owner

Others commented Jun 5, 2020

This is kinda awkward and needs refactoring, but we should do a double check of the Lockout before deallocating data. This will be pretty fast on the happy path, and would catch some UB surrounding deallocation in bad code. The perf loss is definitely worth it.
@Others Others added T-enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers T-ergonomics Something code be easier to use labels Jun 5, 2020
@Others Others self-assigned this Jun 5, 2020
@Others Others mentioned this issue Jun 16, 2020
Open
@Others Others removed their assignment Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed T-enhancement New feature or request T-ergonomics Something code be easier to use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Others