From 10a41d469ccafa1281094af4532954614d57dd64 Mon Sep 17 00:00:00 2001 From: Github Actions Date: Tue, 1 Aug 2023 10:30:27 +0000 Subject: [PATCH 1/5] Version bump --- box.json | 2 +- changelog.md | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/box.json b/box.json index ad868d4..ca49c81 100644 --- a/box.json +++ b/box.json @@ -1,6 +1,6 @@ { "name":"TestBox", - "version":"5.3.0", + "version":"5.4.0", "location":"https://downloads.ortussolutions.com/ortussolutions/testbox/@build.version@/testbox-@build.version@.zip", "author":"Ortus Solutions ", "slug":"testbox", diff --git a/changelog.md b/changelog.md index a370f81..85911bf 100644 --- a/changelog.md +++ b/changelog.md @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [5.3.0] - 2023-08-01 + ### New Features - [TESTBOX-379](https://ortussolutions.atlassian.net/browse/TESTBOX-379) New expectations: `toBeIn(), toBeInWithCase()` so you can verify a needle in string or array targets @@ -78,7 +80,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [TESTBOX-365](https://ortussolutions.atlassian.net/browse/TESTBOX-365) New build process using CommandBox - [TESTBOX-372](https://ortussolutions.atlassian.net/browse/TESTBOX-372) Adobe 2023 and Lucee 6 Support -[Unreleased]: https://github.com/Ortus-Solutions/TestBox/compare/v5.2.0...HEAD +[Unreleased]: https://github.com/Ortus-Solutions/TestBox/compare/v5.3.0...HEAD + +[5.3.0]: https://github.com/Ortus-Solutions/TestBox/compare/v5.2.0...v5.3.0 [5.2.0]: https://github.com/Ortus-Solutions/TestBox/compare/v5.1.0...v5.2.0 From d899892a703ebeb466698cd863db90f6f3543013 Mon Sep 17 00:00:00 2001 From: Laurence Date: Wed, 16 Aug 2023 08:47:23 -0600 Subject: [PATCH 2/5] Update BDDRunner.cfc (#150) * Update BDDRunner.cfc variable thisSuite isn't defined if the for loop is never reached. * Update BDDRunner.cfc Changed to ternary operation per Luis. --- system/runners/BDDRunner.cfc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/runners/BDDRunner.cfc b/system/runners/BDDRunner.cfc index f2edc87..734b36d 100644 --- a/system/runners/BDDRunner.cfc +++ b/system/runners/BDDRunner.cfc @@ -153,7 +153,7 @@ component e, arguments.target, arguments.testResults, - thisSuite + isNull( thisSuite ) ? {} : thisSuite ] ); } From 6bcbad1bb3f74ac01e8dbe56e3363ad921424f7b Mon Sep 17 00:00:00 2001 From: Luis Majano Date: Wed, 16 Aug 2023 17:40:20 +0200 Subject: [PATCH 3/5] install testbox cli --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f663b23..56bbc52 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -49,6 +49,7 @@ jobs: uses: Ortus-Solutions/setup-commandbox@v2.0.1 with: version: ${{ matrix.commandbox_version }} + install: testbox-cli - name: Install Dependencies run: | From 68be7cf6d1f7b9b4191d840976e97741ba600ee1 Mon Sep 17 00:00:00 2001 From: Luis Majano Date: Thu, 17 Aug 2023 12:56:27 +0200 Subject: [PATCH 4/5] matrix experimental allow failures --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 56bbc52..0af0e93 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -11,6 +11,7 @@ jobs: tests: name: Test Suites runs-on: ubuntu-20.04 + continue-on-error: ${{ matrix.experimental }} strategy: fail-fast: false matrix: From 9b0d575812ac37c6d8554358a2dbb335f69381ef Mon Sep 17 00:00:00 2001 From: Luis Majano Date: Wed, 13 Sep 2023 15:13:50 +0200 Subject: [PATCH 5/5] finalized for patch release --- box.json | 2 +- changelog.md | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/box.json b/box.json index ca49c81..08e0632 100644 --- a/box.json +++ b/box.json @@ -1,6 +1,6 @@ { "name":"TestBox", - "version":"5.4.0", + "version":"5.3.1", "location":"https://downloads.ortussolutions.com/ortussolutions/testbox/@build.version@/testbox-@build.version@.zip", "author":"Ortus Solutions ", "slug":"testbox", diff --git a/changelog.md b/changelog.md index 85911bf..b1c2a70 100644 --- a/changelog.md +++ b/changelog.md @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +- The variable `thisSuite` isn't defined if the for loop in the try/catch is never reached before the error. + (https://github.com/Ortus-Solutions/TestBox/pull/150) + ## [5.3.0] - 2023-08-01 ### New Features