Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change when callstack is obtained #87

Open
martindsouza opened this issue Mar 3, 2015 · 1 comment
Open

Change when callstack is obtained #87

martindsouza opened this issue Mar 3, 2015 · 1 comment
Milestone

Comments

@martindsouza
Copy link
Member

Currently each of the logger.log_xyz procedures calls log_internal(... p_callstack => dbms_utility.format_call_stack ...). Then log_internal will determine if the callstack should be displayed and parsed.

This may be a performance issue since dbms_utility.format_call_stack may not be required when the callstack option is turned off. I.e. we should put the check to determine callstack (include_call_stack) in each of the logger.log_xyz procedures calls.

@martindsouza martindsouza self-assigned this Mar 3, 2015
@martindsouza martindsouza added this to the Release 3.1.0 milestone Mar 16, 2015
@martindsouza martindsouza removed their assignment May 1, 2015
@martindsouza martindsouza modified the milestones: Future, Release 3.1.0 May 30, 2015
@martindsouza
Copy link
Member Author

Took out for Release 3.1.0. Would require duplicating code for each logger.log_xyz procedure and may not be worth maintaining the additional code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant