Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to the app #11

Open
2 tasks
mimotej opened this issue Jun 21, 2022 · 4 comments
Open
2 tasks

Add logging to the app #11

mimotej opened this issue Jun 21, 2022 · 4 comments

Comments

@mimotej
Copy link
Collaborator

mimotej commented Jun 21, 2022

It would be good for future debugging to add logging to the app.

Acceptance criteria

  • Investigate logging methods
  • Add one method to the app
@tkosci
Copy link
Contributor

tkosci commented Feb 20, 2023

This could be covered by these two solutions.
Most used dedicated packages for logging are apparently typescript-logging and tslog. If we ignore javascript modules and plain console logging, the latter option would be propably better, since it seems easier to set up and more feature rich.

@mimotej
Copy link
Collaborator Author

mimotej commented Feb 20, 2023

This could be covered by these two solutions. Most used dedicated packages for logging are apparently typescript-logging and tslog. If we ignore javascript modules and plain console logging, the latter option would be propably better, since it seems easier to set up and more feature rich.

I think best option is to use console logging no need for any additional dependencies for the project of this size.

@tkosci
Copy link
Contributor

tkosci commented Feb 20, 2023

It would mean less dependencies, but wouldn't provide f.e. severity of the log entry and would potentialy create a tech debt with the project size increasing in the future.

@mimotej
Copy link
Collaborator Author

mimotej commented Feb 20, 2023

It would mean less dependencies, but wouldn't provide f.e. severity of the log entry and would potentialy create a tech debt with the project size increasing in the future.

I don't think this project can get to the size where using simpler logging tools would create a tech debt (mind it contains other methods such as console.warn, console.error so it already has basic tools for logging). On the other hand it will ensure that if this project would get into the maintenance mode there would be one less library we need to keep updated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants