Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Opentrons simulate pick up tip message formatting #16178

Open
wants to merge 2 commits into
base: chore_release-8.0.0
Choose a base branch
from

Conversation

CaseyBatten
Copy link
Contributor

Overview

Cover RQA-3129

Originally we were printing only the primary well referenced in a pick up tip action in simulate. This has lead to confusion and incomplete information when engaging in partial tip extraction. This PR seeks to ensure we trace the selecition of tips being removed back to the edge-well of a given cluster of tips.

As a result, the follow case would be true:

Flex 8ch Partial tip Pickup using 2 nozzles picking up from a tiprack would print:
Picking up tips from A1-B1 of Opentrons Flex 96 Tip Rack 1000 µL on slot B2

Test Plan and Hands on Testing

Ensure all configurations of pipette layout list tip extraction well reference in sensible order.

Changelog

String formatting on outgoing pick up tip command.

Review requests

Risk assessment

Low - only effects outgoing string.

This has had the unfortunate knock-on effect of making the simulate print log more accurate than the current run-preview log.

@CaseyBatten CaseyBatten requested a review from a team as a code owner September 3, 2024 15:22
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks good to me for pick up tip. I think we want this for anything else that is relevant though, right? drop_tip, aspirate, dispense, anything that targets wells

@ecormany
Copy link
Contributor

ecormany commented Sep 3, 2024

I agree with Seth. Especially within a transfer, the pickup, aspirate, and dispense all get written out right next to each other. With this change, it can look like this:

Transferring 100.0 from D1 of Corning 96 Well Plate 360 µL Flat on slot B2 to D2 of Corning 96 Well Plate 360 µL Flat on slot B2
	Picking up tip from A1-D1 of Opentrons Flex 96 Tip Rack 1000 µL on slot D1
	Aspirating 100.0 uL from D1 of Corning 96 Well Plate 360 µL Flat on slot B2 at 716.0 uL/sec
	Dispensing 100.0 uL into D2 of Corning 96 Well Plate 360 µL Flat on slot B2 at 716.0 uL/sec

That's aspirating from A1–D1 and dispensing into A2–D2.

@y3rsh
Copy link
Member

y3rsh commented Sep 4, 2024

We have made the call to add it this as a known issue due to the amount of work yet needed and other bugs taking priority.

@y3rsh y3rsh added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants