Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test #4041

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

test #4041

wants to merge 2 commits into from
+10 −13

Conversation

Anzooooo
Copy link
Member

No description provided.

@Anzooooo
fix(st-ld forward): modify misaligned forward fault detection
22eb9ad
@Anzooooo
fix(bank_conflict): fix oldest selection logic
e2fd6e9 
Changes in this Commit(8ffb12e) will make:
In this case, there will be multiple replay: ldu0,1,2's lqptr= [5,7,6], bank_conflict only in ldu1 and ldu2. Ideally only replay ldu1, but here both ldu1 and ldu2 will replay.

This mod fixes the issue and theoretically performance will improve again.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: e2fd6e9

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
e2fd6e9 1.952 0.450 2.699 1.228 2.847 2.457 2.394 0.933 1.425 1.979 3.418 2.727 2.383 3.272

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c7ca40e 1.937 0.451 2.697 1.227 2.866 2.462 2.393 0.930 1.425 2.054 3.437 2.718 2.367 3.210
38d0d7c
8ffb12e
99baa88 1.899 0.450 2.701 1.219 2.833 2.461 2.395 0.921 1.426 2.022 3.432 2.707 2.368 3.227
f346d72 1.899 0.450 2.701 1.219 2.833 2.461 2.395 0.921 1.426 2.022 3.432 2.707 2.368 3.227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4e cz4e Awaiting requested review from cz4e cz4e will be requested when the pull request is marked ready for review cz4e is a code owner

@good-circle good-circle Awaiting requested review from good-circle good-circle will be requested when the pull request is marked ready for review good-circle is a code owner

@linjuanZ linjuanZ Awaiting requested review from linjuanZ linjuanZ will be requested when the pull request is marked ready for review linjuanZ is a code owner

@happy-lx happy-lx Awaiting requested review from happy-lx happy-lx will be requested when the pull request is marked ready for review happy-lx is a code owner

@bosscharlie bosscharlie Awaiting requested review from bosscharlie bosscharlie will be requested when the pull request is marked ready for review bosscharlie is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anzooooo @XiangShanRobot