fix(st-ld forward): modify misaligned forward fault
detection
#4038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I used an inappropriate way for another misalign to trigger a
forward fault
:XiangShan/src/main/scala/xiangshan/mem/lsqueue/StoreQueue.scala
Lines 684 to 711 in 38d0d7c
This would cause the
BlockSqIdx
passed toLoadQueueReplay
to use thesqIdx
fromuop
instead of thesqIdx
with the unalign flag bit:XiangShan/src/main/scala/xiangshan/mem/lsqueue/StoreQueue.scala
Lines 776 to 782 in 38d0d7c
This leads to a possible stuck in
LoadQueueReplay
.And to resolve the stuck, we incorrectly introduced this Commit(af757d1).
This Commit(af757d1) causes
BlockSqIdx
to unblock withoutDataValid
.This leads to certain performance issues.
This revision fixes the inappropriate
forward fault
triggering method and reverses the Commit(af757d1).This should bring performance back up again.
Apologies for my mistake.