Skip to content

Commit

Permalink
fix(StoreQueue): fix the vecExceptionFlag setting condition (#4037)
Browse files Browse the repository at this point in the history
Only if `dataBuffer.io.enq.fire` is considered to have `deq`
  • Loading branch information
Anzooooo authored Dec 13, 2024
1 parent f346d72 commit 99baa88
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/main/scala/xiangshan/mem/lsqueue/StoreQueue.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1255,12 +1255,12 @@ class StoreQueue(implicit p: Parameters) extends XSModule
// If the last flow with an exception is the LastFlow of this instruction, the flag is not set.
// compare robidx to select the last flow
require(EnsbufferWidth == 2, "The vector store exception handle process only support EnsbufferWidth == 2 yet.")
val robidxEQ = dataBuffer.io.enq(0).valid && dataBuffer.io.enq(1).valid &&
val robidxEQ = dataBuffer.io.enq(0).fire && dataBuffer.io.enq(1).fire &&
uop(rdataPtrExt(0).value).robIdx === uop(rdataPtrExt(1).value).robIdx
val robidxNE = dataBuffer.io.enq(0).valid && dataBuffer.io.enq(1).valid && (
val robidxNE = dataBuffer.io.enq(0).fire && dataBuffer.io.enq(1).fire && (
uop(rdataPtrExt(0).value).robIdx =/= uop(rdataPtrExt(1).value).robIdx
)
val onlyCommit0 = dataBuffer.io.enq(0).valid && !dataBuffer.io.enq(1).valid
val onlyCommit0 = dataBuffer.io.enq(0).fire && !dataBuffer.io.enq(1).fire

val vecCommitLastFlow =
// robidx equal => check if 1 is last flow
Expand Down

0 comments on commit 99baa88

Please sign in to comment.