Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Restore 3rd party dependencies using NuGet for MSVC generator #1624

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

pavel-rodionov
Copy link
Contributor

Attempt to bring project closer to migration from hardcoded MSVS solutions to Cmake based generator.

Verification:

  • Install nuget cli winget install -e --id Microsoft.NuGet
  • Run Cmake generator cmake ..\xray-16 -G "Visual Studio 17 2022" -A x64 -DXRAY_USE_LUAJIT=OFF
  • Verify that packages listed as nuget dependencies are downloaded into ./packages
  • Open MSVC solution. Verify that target xrLC_Light does include d3dx9 headers and they are included from expected location ..\..\..\packages\Microsoft.DXSDK.D3DX.9.29.952.8\build\native\include\d3dx9.h

@github-actions github-actions bot added Renderer External (3rd party) This issue is related to external component used by our project. labels Mar 3, 2024
@MerijnHendriks
Copy link
Contributor

Is nuget from dotnet sdk also usable with this pr? What about offline builds? (nuget restore requires an internet connection, otherwise build fails).

@pavel-rodionov
Copy link
Contributor Author

@MerijnHendriks
If nuget cli is available in your system PATH it should work. With that said I haven't tested it.

Regarding offline builds - when files are already downloaded and available in local file system it works offline just fine. To initially restore files you obviously need an active network connection (that is on pair with current solution when VS restore them using dependencies defined in solutions)

@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from 5b2ec76 to 6fffce9 Compare May 4, 2024 03:27
@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from e89fcc8 to f6fd5cc Compare October 24, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External (3rd party) This issue is related to external component used by our project. Renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants