Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circulator: Add missing controls. #382

Open
zelch opened this issue Dec 23, 2024 · 1 comment
Open

Circulator: Add missing controls. #382

zelch opened this issue Dec 23, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@zelch
Copy link

zelch commented Dec 23, 2024

Current Situation

Currently, the functionality provided via the API for the circulator fan and battery circulator fan is pretty limited.

You can turn it on and off, you can set the 'wind mode', you can set the speed, and you can control the night light.

But you can't do anything at all with the horizontal or vertical controls.

Proposed Change

Add commands for:

  • setOscillation on/off
  • setVerticalOscillation on/off
  • turnLeft
  • turnRight
  • turnCenter
  • tiltUp
  • tiltDown
  • tiltLevel

Though, as a significant note, I don't know how the turn and tilt commands are implemented internally to the fan, if the device itself can return information on the current turn and/or tilt, that information should be added to the various reporting functions.

Likewise, if it is possible to tell the device to turn or tilt to a specific position, then a turn or tilt command that takes a position argument would be vastly preferred.

Additional Context

Broadly speaking, the goal is to provide, at a minimum, sufficient functionality to perform the same actions as the app is capable of performing.

As a complete aside, it would be convenient if the same methods for controlling turn and tilt were also provided for controlling the Pan/Tilt cameras, however I definitely understand if the internal implementations are different enough that sharing that part of the API is not practical.

@zelch
Copy link
Author

zelch commented Dec 23, 2024

Note, this is strictly speaking a superset of the features requested in #373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants