Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when all template lines fail to expand #318

Open
coderabbitai bot opened this issue Dec 6, 2024 · 0 comments
Open

Improve error handling when all template lines fail to expand #318

coderabbitai bot opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

When all lines fail to expand during template rendering, an exception should be thrown. If at least one line expands successfully, failed lines should be logged and ignored, allowing processing to continue.

PR: #317
Comment: #317 (comment)
Requester: @JarbasAl

Learning: In ovos_utils/dialog.py, when all lines in a template fail to expand during rendering, an exception should be thrown. If at least one line expands successfully, any failed lines should be logged, the bad lines dropped, and processing should continue since there is enough data to proceed.

@JarbasAl JarbasAl added the bug Something isn't working label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant