Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot does not install the extras extra #226

Open
mikejgray opened this issue Jan 31, 2024 · 0 comments
Open

Dependabot does not install the extras extra #226

mikejgray opened this issue Jan 31, 2024 · 0 comments

Comments

@mikejgray
Copy link
Contributor

rapidfuzz was upgraded to a significantly higher version, which drops compatibility with 3.7. The Dependabot PR didn't catch that because it's doesn't run unit tests, and the build tests try to install the [all] extra (which doesn't exist).

Identified in unit tests on this PR: https://github.com/OpenVoiceOS/ovos-utils/actions/runs/7721017873/job/21046877080

I'm also not sure pinning to a version that new is a good idea when there were no compatibility issues with the older version - I do see some good-sized vulnerability fixes there though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant