Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condition / report timeframe logic #17

Open
emphasize opened this issue Oct 21, 2022 · 0 comments
Open

condition / report timeframe logic #17

emphasize opened this issue Oct 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@emphasize
Copy link
Member

emphasize commented Oct 21, 2022

this came up while thinking about #14

if i'm asking about a condition (clear, rain, snow, thunderstorm, ...) on a specific day, the report timeframe is set to DAILY. *)

This would mean, the condition has to be dominant across the day - or in case of "today" happening right now. Otherwise it isn't reported. While this is inevitable for future events > 48 hours (hourly data constraint), it is nonsense below.

If you're asking for a thunderstorm you care about the happening, not if it is the dominant condition of the day. If the day in question is within 48 hours, hourly data should be used.

That said, in my fork i handle upcoming conditions a bit more extensive.

  • the time it happens
  • the duration
  • in case of precipitation the volume (rain_vol, snow_vol)

This might be a usefull addition for OVOS

*) Worse than that, if asked for "today" the timeframe isn't set, with the default being CURRENT - i.e. the current condition.
("today" isn't even a part of relative-day.voc)

@JarbasAl JarbasAl added the enhancement New feature or request label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants