Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with volume in italian #25

Open
denics opened this issue Aug 11, 2023 · 4 comments
Open

issue with volume in italian #25

denics opened this issue Aug 11, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@denics
Copy link
Contributor

denics commented Aug 11, 2023

In docker, when I try to set the volume in Italian, I get:

  • hey mycroft, imposta il volume a 10 (set volume to 10)
  • Il volume è a 50 (the volume is 50) which is not the answer I am waiting from it. It this is the docker behavior I think it should be documented, but I doubt so, I ALWAYS get 50 as an answer (not even 42)
@goldyfruit
Copy link
Member

This skill is sending a mycroft.volume.set message to the bus with to the requested volume setting, then its the PHAL ALSA plugin that handles the message using the alsaaudio Python library.

I'm facing the same behaviour.

@goldyfruit
Copy link
Member

goldyfruit commented Aug 11, 2023

When I set the volume from the ovos_phal container via the Python interpreter it works, which means the container has the right access to ALSA mixers.

ovos@ovos_phal:~$ python
Python 3.11.2 (main, Mar 13 2023, 12:18:29) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import alsaaudio
>>> print(alsaaudio.mixers())
['Master', 'Capture']
>>> mixer = alsaaudio.Mixer("Master")
>>> mixer.getvolume()
[15, 14]
>>> mixer.setvolume(50)
>>> mixer.getvolume()
[50, 50]

@emphasize
Copy link
Member

emphasize commented Sep 27, 2023

Thats a locale problem (autotranslate)
To set an absolute volume it needs change and volume (adapt)

whereas to get the current volume only volume is required. Therefor the answer.

also check the "louder"/"quieter" intent where only louder/quieter is needed to increase/decrease by 10% (without a relative number) or x% (with number)

Non-english client users should look at the locale as this is very likely the problem.

@JarbasAl JarbasAl added the bug Something isn't working label Sep 27, 2023
@denics
Copy link
Contributor Author

denics commented May 13, 2024

Probably #30 will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants