Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop lingua-franca #71

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: drop lingua-franca #71

merged 2 commits into from
Nov 11, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 7, 2024

Summary by CodeRabbit

  • New Features

    • Improved date and time handling capabilities in the TimeSkill class.
    • Enhanced localization support for datetime extraction from user input.
    • Integration of external libraries for date formatting and utterance normalization.
  • Bug Fixes

    • Updated timezone detection for better accuracy based on user input.
  • Chores

    • Added new dependencies for enhanced date parsing and utterance normalization.

Copy link

coderabbitai bot commented Nov 7, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the __init__.py file and updates to the requirements.txt. The __init__.py file sees the removal of the nice_weekday and nice_month methods from the TimeSkill class, replaced by functionality from the ovos_date_parser module. The initialize method now caches language settings for date and time formatting, and the _get_timezone_from_fuzzymatch method has been enhanced for better timezone detection. Additionally, the handle_query_future_time method has been updated to utilize the UtteranceNormalizerPlugin. The requirements.txt file has been updated to include two new dependencies.

Changes

File Change Summary
__init__.py Removed nice_weekday and nice_month methods; updated handle_query_future_time to use UtteranceNormalizerPlugin; modified timezone detection and caching of language settings.
requirements.txt Added dependencies: ovos-date-parser>=0.0.1,<1.0.0 and ovos-utterance-normalizer>=0.0.1,<1.0.0.

Poem

In the code where time does play,
A rabbit hops and shapes the day.
With new tools to format and parse,
We dance through dates, oh how we farce!
Dependencies added, our skills refined,
In the world of code, joy we find! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the fix label Nov 7, 2024
@JarbasAl JarbasAl marked this pull request as draft November 7, 2024 10:39
@JarbasAl JarbasAl marked this pull request as ready for review November 11, 2024 15:19
@JarbasAl JarbasAl merged commit e71d1f9 into dev Nov 11, 2024
7 of 8 checks passed
@JarbasAl JarbasAl deleted the droplf branch November 11, 2024 15:21
@github-actions github-actions bot added fix and removed fix labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant