Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use configuration for streaming TTS play args #238

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

mikejgray
Copy link
Contributor

Closes #218

@mikejgray mikejgray force-pushed the FIX_StreamingTTSConfig branch from 06d675b to 042dd4d Compare June 25, 2024 02:31
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@9857a3e). Learn more about missing BASE report.

Files Patch % Lines
ovos_plugin_manager/templates/tts.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #238   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      58           
  Lines          ?    4445           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    4445           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejgray
Copy link
Contributor Author

mikejgray commented Jun 25, 2024

Didn't fix...I should say it does fix it, but it doesn't play properly with afplay or vlc

@mikejgray mikejgray marked this pull request as draft June 25, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming TTS is only usable with paplay
1 participant