Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounds for timeout valye #59

Open
JarbasAl opened this issue Oct 23, 2023 · 0 comments
Open

bounds for timeout valye #59

JarbasAl opened this issue Oct 23, 2023 · 0 comments

Comments

@JarbasAl
Copy link
Member

          If there’s a possibility the timeout can be changed at runtime to an unsuitable value, it might be worth the hit from setting it where it was before, but with bounds.

Otherwise, this solves the problem.

Originally posted by @ChanceNCounter in #58 (review)

from matrix chat

@JarbasAl

what should that upper limit be? this is how long a adapt context can remain valid
if we want it to be valid forever, lets support -1 for no timeout
otherwise what is sane? 1 day?

@ChanceNCounter

There’s probably an answer here, but idk how to estimate it. A day seems like overkill, but maybe not idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant