Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/fallbackV1 #135

Merged
merged 1 commit into from
Sep 30, 2023
Merged

fix/fallbackV1 #135

merged 1 commit into from
Sep 30, 2023

Conversation

JarbasAl
Copy link
Member

solve issues found in unittests for compat with FallbackSkillV1
@JarbasAl JarbasAl added the bug Something isn't working label Sep 30, 2023
JarbasAl added a commit to OpenVoiceOS/ovos-core that referenced this pull request Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bc265e9) 57.48% compared to head (8ca074a) 57.65%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #135      +/-   ##
==========================================
+ Coverage   57.48%   57.65%   +0.16%     
==========================================
  Files          34       34              
  Lines        3319     3306      -13     
==========================================
- Hits         1908     1906       -2     
+ Misses       1411     1400      -11     
Files Coverage Δ
ovos_workshop/skills/fallback.py 60.69% <100.00%> (+2.75%) ⬆️
ovos_workshop/version.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 21a036f into dev Sep 30, 2023
9 checks passed
@JarbasAl JarbasAl deleted the unittests/fallbackv1 branch September 30, 2023 16:46
JarbasAl added a commit to OpenVoiceOS/ovos-core that referenced this pull request Sep 30, 2023
unittests for compat with FallbackSkillV1

requires OpenVoiceOS/OVOS-workshop/pull/135
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant