Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shellcheck directives and minor tweak #1105

Merged
merged 1 commit into from
Apr 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion easyrsa3/easyrsa
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,7 @@ Type the word '$value' to continue, or any other input to abort."
printf '\n'
[ "$input" = "$value" ] && return
easyrsa_exit_with_error=1
unset -v EASYRSA_SILENT
notice "Aborting without confirmation."
cleanup
} # => confirm()
Expand Down Expand Up @@ -1496,7 +1497,8 @@ locate_support_files() {
hide_read_pass() {
# 3040 - In POSIX sh, set option [name] is undefined
# 3045 - In POSIX sh, some-command-with-flag is undefined
# shellcheck disable=SC3040,SC3045 # POSIX - hide_read_pass()
# 3061 - In POSIX sh, read without a variable is undefined.
# shellcheck disable=SC3040,SC3045,SC3061
if stty -echo 2>/dev/null; then
prompt_restore=1
read -r "$@"
Expand Down Expand Up @@ -3557,6 +3559,7 @@ Missing User Certificate, expected at:
error_info="SSL library may not support -legacy mode"

# export the p12:
# shellcheck disable=2086 # Double quote p12_cipher_opts
easyrsa_openssl pkcs12 -export \
-in "$crt_in" \
-out "$pkcs_out" \
Expand Down Expand Up @@ -5761,6 +5764,7 @@ case "$cmd" in
# easyrsa-tools.lib is required
if [ -e "$EASYRSA_TOOLS_LIB" ]; then
export EASYRSA_TOOLS_CALLER=1
# shellcheck disable=SC1090 # can't follow non-constant..
. "$EASYRSA_TOOLS_LIB" || \
die "Source failed: $EASYRSA_TOOLS_LIB"
unset -v EASYRSA_TOOLS_CALLER
Expand Down