Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip nearestTaxonMRCAName and nearestTaxonMRCAOttID #3

Open
mtholder opened this issue Jan 20, 2015 · 3 comments
Open

strip nearestTaxonMRCAName and nearestTaxonMRCAOttID #3

mtholder opened this issue Jan 20, 2015 · 3 comments

Comments

@mtholder
Copy link
Member

these are sporadic and possibly stale when present:
see irc discussion on http://irclog.perlgeek.de/opentreeoflife/2015-01-20
and the previous issue that @jimallman found: OpenTreeOfLife/opentree#365

@jimallman
Copy link
Member

@mtholder, note that I'm stripping four properties in the curation app:

  • tree['^ot:MRCAName']
  • tree['^ot:MRCAOttId']
  • tree['^ot:nearestTaxonMRCAName']
  • tree['^ot:nearestTaxonMRCAOttId']

These store the results for the taxonomic and synthetic MRCA tests, respectively. I assumed we would treat these the same, yes?

@jimallman
Copy link
Member

@mtholder And lo, these many years later, we want this information handy for the curation of tree collections. I see that they're still offered in our API's v3/studies/properties call. I don't need them to be stored in the Nexson, but at least available in otindex. Perhaps these MRCA tests could be run whenever a study is updated in phylesystem?

@snacktavish
Copy link
Member

https://github.com/OpenTreeOfLife/germinator/wiki/Synthetic-tree-API-v3#mrca
Ah interesting. If we are thinking about synth MRCA's, these can change not only when the study is updated, but also if the study stays the same and the synth tree is updated.
And the same is true of taxon MRCA's when the taxonomy changes.

We don't have update triggers for either of these changes in otindex, so it would be easy for them to get stale. But I suppose doing those calls each time would be slow. Perhaps good to discuss on the call today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants