Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single digit study IDs #1

Open
mtholder opened this issue Jun 17, 2014 · 3 comments
Open

single digit study IDs #1

mtholder opened this issue Jun 17, 2014 · 3 comments
Assignees

Comments

@mtholder
Copy link
Member

this is currently a mess due to changing code and aliasing covering up inconsistencies:
studyID ot_9 is in study/ot__9/ot_9/ot_9.json
studyID pg_09 is study 9 in phylografter and is in pg_09/pg_09/pg_09.json

this is not an emergency because the studyID's listed in the files, resolve.
But I should clean it up at some point. Probably no point in fixing the code that generated the mess (because we are passed single digit IDs in both the ot and pg namespaces), but better aliasing (in peyotl) and some git mv operations would make the system more transparent.

@mtholder mtholder self-assigned this Jun 17, 2014
@jimallman
Copy link
Member

@mtholder: Is this bug restricted to code that imports from phylografter? Or could this become a problem again if introduce a third "namespaced" source for studies?

@mtholder
Copy link
Member Author

I'm sorry to say that this would bite us if we added a new namespace... (a hack would be to add 10 bogus studies in a new namespace so that it would not affect any real studies )

@jar398
Copy link
Member

jar398 commented Oct 1, 2016

why not just start the counter at 10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants